Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit convert_time_format for a CxoTime object #40

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Nov 11, 2023

Description

This is a minor change to improve performance for a corner case when convert_time_format is called with a CxoTime object. In that case the fastest path is to use the object attribute.

Interface impacts

None

Testing

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Linux

Functional tests

No functional testing.

@taldcroft taldcroft requested a review from jeanconn November 11, 2023 16:07
@taldcroft taldcroft merged commit 7511e59 into master Nov 13, 2023
2 checks passed
@taldcroft taldcroft deleted the short-circuit-for-time-object branch November 13, 2023 17:55
@javierggt javierggt mentioned this pull request Dec 5, 2023
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants