Check that the last kadi dwell < 3 days old #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
commented
Jun 14, 2021
| dwells = events.dwells.filter(-20) | ||
| last_dwell = dwells[len(dwells) - 1] | ||
| self.filetime = CxoTime(last_dwell.start).unix | ||
| self.filedate = time.ctime(self.filetime) |
There was a problem hiding this comment.
This is clunky but I didn't see a driver to update the formatting of the rest of the time strings.
taldcroft
reviewed
Jun 21, 2021
|
Actually I don't see any description of testing, so not quite approved. |
|
Oops. Updated text with testing. |
taldcroft
approved these changes
Jun 25, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the last kadi dwell < 3 days old
For testing, I ran this as
jobwatch.skawatch.main()and reviewed the output HTML. It seems reasonable:Independent inspection of kadi dwells shows the last stop time about 0.62 days from "now". I didn't confirm the time in local but seems reasonable.
When I ran this code two weeks ago when kadi was stuck, I saw the "red" that I expected in the report (code has changed a bit since then, but same idea).