Optionally use MAUDE to get star data for find_attitude #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
commented
Aug 20, 2022
|
Consider using blobs instead of |
taldcroft
force-pushed
the
find-attitude-use-maude
branch
from
30066cc to
9f322e6
Compare
|
The reason why this is still open is that maude requires authentication, and the web server is run by a separate user. That means we would need to decide to add credentials in that user's home directory or handla authentication within the web app. That is why there is PR #16 (WIP). |
|
@javierggt - I believe the web server user already has the right credentials. |
|
And I think the app should use those available credentials instead of requiring the user to enter them. And note the commit message in #16: "Include user auth for MAUDE (not quite working?)". |
javierggt
reviewed
Nov 8, 2023
| tbl['YAG'] = [out[f"AOACYAN{ii}"] for ii in range(8)] | ||
| tbl['ZAG'] = [out[f"AOACZAN{ii}"] for ii in range(8)] | ||
| tbl['MAG_ACA'] = [out[f"AOACMAG{ii}"] for ii in range(8)] | ||
| tbl.meta['date_solution'] = CxoTime(date).date |
There was a problem hiding this comment.
How about this?
tbl.meta['date_solution'] = CxoTime(results[0]['times'][-1]).date
javierggt
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optionally use MAUDE to get star data for find_attitude.
Closes #16
Closes https://github.com/sot/ska-projects/issues/51
Interface impacts
Adds a new field and functionality to the kadi
find_attitudepage.Testing
Unit tests
Functional tests
Star datafield and confirmed that MAUDE is used.