Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ska_helpers.utils.convert_to_int_float_str to stop Deprecation warns #296

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jeanconn
Copy link
Contributor

Use ska_helpers.utils.convert_to_int_float_str directly instead of parse_cm.common._coerce_type .

Description

Stops warnings like

kadi/commands/tests/test_states.py: 1 warning
  /fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/parse_cm/common.py:33: VisibleDeprecationWarning: The _coerce_type function is deprecated and will be removed in a future version of parse_cm. Use ska_helpers.utils.convert_to_int_float_str instead.
    warnings.warn(

Interface impacts

Testing

Tested in ska3-masters with https://github.com/sot/parse_cm/pull/44

Unit tests

  • Linux

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Unit tests with and without this PR show no warning with PR and warning without and otherwise pass.

@jeanconn jeanconn merged commit 11b8177 into master Oct 24, 2023
3 checks passed
@jeanconn jeanconn deleted the coerce-type branch October 24, 2023 20:01
@javierggt javierggt mentioned this pull request Dec 5, 2023
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants