Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden setup.py package data glob to install pkl.gz and ecsv.gz test data #303

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Nov 25, 2023

Description

Broaden setup.py package data glob to install pkl.gz and ecsv.gz test data. This is a tiny fix for #300 .

Interface impacts

Testing

Tested with a local ska3-masters but with this kadi PR "python setup.py installed".

Unit tests

  • Linux

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Unit tests don't pass without this fix and show errors like

E           FileNotFoundError: validation regression data /fido.real/conda/envs/ska3-masters/lib/python3.10/site-packages/kadi/commands/tests/data/validators_2022297_5_True.pkl.gz not found.
E           Run `python -m kadi.commands.tests.test_validate` to generate it.

@jeanconn jeanconn requested a review from taldcroft November 25, 2023 16:24
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course...

@taldcroft taldcroft merged commit b034d11 into master Nov 25, 2023
4 checks passed
@jeanconn jeanconn deleted the install-validation-data branch November 29, 2023 20:12
@javierggt javierggt mentioned this pull request Dec 5, 2023
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants