Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude COLOR1=0.7 stars from guide selection #401

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Oct 2, 2024

Description

Exclude COLOR1=0.7 stars from guide selection.

We decided to not use COLOR1=0.7 stars for guide at the 2024x09x11 SS&AWG meeting. We implemented that immediately via adding those stars to the 'bad' table in the supplement, but the idea here is that it is simpler to just add that to the mask and then remove the stars from bad table.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-latest) flame:proseco jean$ git rev-parse HEAD
a2f1012b84875ece373fb923e0ebed85d6f39b04
(ska3-flight-latest) flame:proseco jean$ pytest
===================================================== test session starts ======================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 168 items                                                                                                            

proseco/tests/test_acq.py .....................................                                                          [ 22%]
proseco/tests/test_catalog.py ..........................................                                                 [ 47%]
proseco/tests/test_core.py ...........................                                                                   [ 63%]
proseco/tests/test_diff.py ......                                                                                        [ 66%]
proseco/tests/test_fid.py ...............                                                                                [ 75%]
proseco/tests/test_guide.py .....................................                                                        [ 97%]
proseco/tests/test_mon_full_cat.py ....                                                                                  [100%]

===================================================== 168 passed in 24.45s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

I added a new unit test that fails if the COLOR1 != 0.7 filter is not applied.

@jeanconn jeanconn requested a review from taldcroft October 2, 2024 14:42
@jeanconn jeanconn merged commit 9072c82 into master Oct 8, 2024
2 checks passed
@jeanconn jeanconn deleted the no-color-bad-guide branch October 8, 2024 13:14
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants