Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move get_version to child process to prevent environment from being changed as side effect
Description
This issue arised in the context of sot/testr/pull/21.
At the very top of get_version, the module whose version we want is imported. Some modules change the environment, and that can cause undesired effects. One way around it is to get the version in a separate process.
This is not that common. One instance I have seen was importing dea_check, which causes kadi to be imported and adds DJANGO_SETTINGS_MODULE to the environment. The trouble is during testing, where the main process has this import, and then in child processes we get the error:
Testing
Fixes #