Change allowed_rolldev to use chandra_models

[taldcroft]

Description

Use the pitch-roll constraint CSV data file in chandra_models via the interface in ska_helpers.chandra_models to import the table of pitch vs. off-nominal roll data.

Requires

• Add files for the pitch-roll constraint chandra_models#104
• Add support for reading chandra_models data ska_helpers#32

Fixes #26

Interface impacts

No API changes, but smaller available available pitch/roll space available.

Testing

Unit tests

• Mac

Independent check of unit tests by Jean

• Linux ska3-prime 2023.1rc9

Functional tests

No functional testing.

[jeanconn]

I put the updated ska_helpers in PYTHONPATH, updated my $SKA/data/chandra_models to the pitch-roll-constraint branch, and ran tests here and get failed tests that chandra_models isn't at 3.47.

FAILED ska_sun/tests/test_sun.py::test_allowed_rolldev[0.0--1.0] - ValueError: repo tip is not at tag 3.47

This is on linux. Not sure what I'm missing just yet.

[jeanconn]

Overall the "repo tip is not at tag" thing keeps biting me. More a ska_helpers issue (if the xija code is going in there) than ska_sun but I could use a "what are we checking and why do we care" overall on this. Did I do something wrong? How is one supposed to work with a test chandra_models? Set some other flag? Make a draft tag?

[jskrist]

@jeanconn, I also bumped on the repo tip is not at tag thing. I think the intention is to make sure that the user is getting the data they expect (typically the latest data), but I wonder if there is a way to check if the data file to be read has any modifications, as local modifications would also cause potentially unexpected data to be returned.

perhaps this should be a log message or warning instead of an exception, or have some way for a power user/dev to skip this check/exception when working in a development environment?

[jeanconn]

@jskrist it looks like it will stop complaining if I add a tag in the testing commit in chandra_models, which is probably a fine work around for the power-testing user.