Add some routines for roll range determination #5
Conversation
|
Not sure what to call the allowed range, I went with "rolldev". Ska.Sun doesn't seem to have any tests, so should probably add some of those too. |
Ska/Sun.py
Outdated
| # segments are flat, however, so this local copy does not bother with the duplication. | ||
| # This ROLL_TABLE does not have all padding needed to provide 100% valid results | ||
| # for planning purposes. | ||
| ROLL_TABLE = Table.read( |
There was a problem hiding this comment.
An inline table seemed easiest to manage, but this can obviously drift from the one in Matlab characteristics.
Ska/Sun.py
Outdated
| :returns: maximum roll deviation / difference from nominal roll | ||
| """ | ||
| idx = np.searchsorted(ROLL_TABLE['pitch'], pitch, side='right') | ||
| return ROLL_TABLE['rolldev'][idx - 1] |
There was a problem hiding this comment.
This presently doesn't return really meaningful results for not-allowed pitch between 0 and 46. Should probably return error instead of just returning 19.99.
|
It looks like this also needs some pads. My impression is also that the range of the useful roll deviation for a target may be somewhat limited by the maneuver profiles, as in if you want to get to the attitude or away from the attitude without an intermediate attitude those maneuvers may constrain the roll range a bit. These routines in Ska.Sun are obviously not going to have that information. |
|
That's my plan. |
|
I think we gave up on this and if we want to we can open a new issue and new approach to move roll determination back here from, say, sparkles. |
Add some routines for roll range determination.