Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the default ska_sync_config #29

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Changes to the default ska_sync_config #29

merged 2 commits into from
Jan 3, 2022

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Dec 16, 2021 •
edited
Loading

Description

This makes a few changes to the default sync config file:

  • Add v2 commands files
  • Sync everything in Ska.TDB (all TDB versions and the CDB)
  • Stop syncing miniagasc_1p7.h5 since miniagasc.h5 is a real file now.

Testing

  • [n/a] Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Functional testing

Used this myself for sync and it worked as expected.

@taldcroft taldcroft requested a review from jeanconn December 31, 2021 15:11
jeanconn
jeanconn reviewed Dec 31, 2021
View reviewed changes
ska_sync/ska_sync_config Outdated Show resolved Hide resolved
@taldcroft taldcroft merged commit c01cf3e into master Jan 3, 2022
@taldcroft taldcroft deleted the taldcroft-patch-1 branch January 3, 2022 21:55
@javierggt javierggt mentioned this pull request Mar 12, 2022
Closed
@javierggt javierggt mentioned this pull request Mar 30, 2022
Merged
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
@javierggt javierggt mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn