Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ska_sync_config for ocat_target_table.h5 #30

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Update ska_sync_config for ocat_target_table.h5 #30

merged 1 commit into from
Dec 21, 2021

Conversation

taldcroft
Copy link
Member

Description

Update ska_sync_config to add ocat_target_table.h5.

Testing

  • [n/a] Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Functional testing

Used this locally and it worked.

@taldcroft taldcroft requested a review from jeanconn December 21, 2021 18:11
jeanconn
jeanconn approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taldcroft taldcroft merged commit db09bd4 into master Dec 21, 2021
@taldcroft taldcroft deleted the taldcroft-patch-2 branch December 21, 2021 21:32
@javierggt javierggt mentioned this pull request Mar 12, 2022
Closed
@javierggt javierggt mentioned this pull request Mar 30, 2022
Merged
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
@javierggt javierggt mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn