Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.5 #1350

Merged
merged 15 commits into from
May 29, 2024
Merged

2024.5 #1350

merged 15 commits into from
May 29, 2024

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented May 13, 2024

ska3-flight 2024.5

This PR includes:

  • updates to chandra_limits to support new ACIS FP limits
  • update to the time range used for High IR Zone checking in starcheck

Note: **This PR includes an ARM build for the first time - that build is intended for beta testing and not operational use **

Closes #1351

Interface Impacts:

chandra_limits : new limits from chandra_models 3.53 are used by the ACIS FP model. Requires chandra_models >= 3.53.

parse_cm: new required_sequenced_duration added to or_list_types.yaml (no impact)

xija: Colors of the new ACIS FP limits in xija_gui_fit and acis_thermal_check will change.

starcheck: Changes to placement of newlines in the text file report.

Testing:

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

The latest release candidates will be installed in /proj/sot/ska3/test on HEAD, and all release candidates will be available for testing from the usual channels:

conda create -n ska3-flight-2024.5rc4 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2024.5rc4

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2024.5 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket and at/after promotion of chandra_models 3.53 .

Code changes

ska3-flight changes (2024.4 -> 2024.5rc3)

Updated Packages

Related Issues

@taldcroft
Copy link
Member

taldcroft commented May 16, 2024

FWIW I confirmed that xija_gui_fit runs as expected on MacOS ARM. I did basic operations of displaying plots, bringing up a histogram and doing a fit of some parameters. The latter validates that sherpa is working as expected.

I also confirmed that aca_view works as expected with back-orbit data.

@jeanconn
Copy link
Contributor

jeanconn commented May 16, 2024

Do you have a functional test we should run for the other platforms? (those are actually all I care about for the flight release)

@taldcroft
Copy link
Member

For xija the functional test is roughly:

xija_gui_fit dpa --days 200
  • Bring up the histogram of residuals.
  • Select about 10 of the solarheat__dpa0__P.. parameters for fitting and hit the Fit button.
  • Confirm that the fit improved and nothing weird happened.

For aca_view I just looked at a random one-hour chunk of telemetry in the last year.

@jeanconn
Copy link
Contributor

I reverted the sherpa update in the now-building rc because it looks like the sherpa 4.16 in current channels needs ciao and I wasn't clear on its status.

Platform: linux-64
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - nothing provides ciao >=4.16.0,<4.16.1.0a0 needed by sherpa-4.16.0-py[31](https://github.com/sot/skare3/actions/runs/9131183444/job/25110083103#step:3:32)1h3fd9d12_0

Could not solve for environment specs
The following package could not be installed
└─ ska3-flight 2024.5rc1  is not installable because it requires
   └─ ska3-core 2024.5rc1 , which requires
      └─ sherpa 4.16 , which requires
         └─ ciao >=4.16.0,<4.16.1.0a0 , which does not exist (perhaps a missing channel).

@javierggt javierggt merged commit 7fd8960 into master May 29, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release ska3-flight 2024.5
3 participants