Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.12 #1450

Merged
merged 1 commit into from
Dec 16, 2024
Merged

2024.12 #1450

merged 1 commit into from
Dec 16, 2024

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Dec 9, 2024

ska3-flight 2024.12

This PR includes:

  • acisfp_check: Update to allow for HRC dependence in the ACIS FP model.
  • chandra_aca: Add some routines to get background subtracted images (relevant only for ACA).
  • maude: Add get_last_backorbit_date function to return the last available backorbit (SSR-dump) data for a list of MSIDs. This is useful to avoid accidentally getting realtime data that may have gaps or corruptions.

Interface Impacts:

  • chandra_aca:
    • dtype of return value in get_aca_images changed.
    • get_aca_images now allows fetching data over time ranges larger than 3 hours
  • maude: Adds a new function get_last_backorbit_date
  • mica: columns in return value of get_aca_images are unmasked, except images.

Testing:

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

The latest release candidates will be installed in /proj/sot/ska3/test on HEAD, and all release candidates will be available for testing from the usual channels:

conda create -n ska3-flight-2024.12rc1 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2024.12rc1

If this release includes an update to ska3-perl, the install process for Aspect will include that. Note: ska3-perl is generally not needed for non-Aspect users.

conda create -n ska3-flight-2024.12rc1 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2024.12rc1 ska3-perl==2024.12rc1

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2024.12 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket.

Code changes

ska3-flight changes (2024.11 -> 2024.12rc1)

Updated Packages

  • aca_view: 0.15.0 -> 0.16.0 (0.15.0 -> 0.16.0)
    • PR 200 (Javier Gonzalez): fix edge case of AcaTelemetryTraverser.set_time
    • PR 203 (Javier Gonzalez): Fix issue Update acdc to 4.3 #202
    • PR 201 (Javier Gonzalez): fix crash in general info widget when one slot has no data
  • acis_thermal_check: 5.1.1 -> 5.2.0 (5.1.1 -> 5.2.0)
    • PR 75 (John ZuHone): Update acisfp_check to allow for HRC dependence in the ACIS FP model
  • agasc: 4.21.2 -> 4.22.0 (4.21.2 -> 4.22.0)
    • PR 195 (Jean Connelly): Update for public use.
    • PR 193 (Javier Gonzalez): add add_pmcorr_columns to agasc.all
  • chandra_aca: 4.47.0 -> 4.48.0 (4.47.0 -> 4.48.0)
    • PR 184 (Jean Connelly): Ruff
    • PR 174 (Jean Connelly): Add some routines to get background subtracted images
    • PR 182 (Tom Aldcroft): get_aca_images() returns MaskedColumns only for data with masked values (except IMG)
    • PR 183 (Tom Aldcroft): Migrate maude_decom to CxoTime
    • PR 181 (Jean Connelly): Use CxoTime.linspace on get_aca_images for > 3hour range
  • cheta: 4.62.1 -> 4.62.2 (4.62.1 -> 4.62.2)
    • PR 265 (Tom Aldcroft): Refresh regression testing and fix ruff / improve variable naming
  • cxotime: 3.9.0 -> 3.9.1 (3.9.0 -> 3.9.1)
    • PR 47 (Jean Connelly): Update linspace step_max docs
  • kadi: 7.13.0 -> 7.14.0 (7.13.0 -> 7.14.0)
    • PR 342 (Tom Aldcroft): Modernize ruff
    • PR 338 (Jean Connelly): Set min_violation_duration to 180s for pcad validation
    • PR 340 (Tom Aldcroft): Improve command states with better transition infrastructure
  • maude: 3.11.1 -> 3.12.0 (3.11.1 -> 3.12.0)
    • PR 46 (Tom Aldcroft): Add get_last_backorbit_date function
  • mica: 4.37.0 -> 4.38.0 (4.37.0 -> 4.38.0)
    • PR 311 (Jean Connelly): Unmask aca image data columns (from get_aca_images) except for IMG
  • parse_cm: 3.16.0 -> 3.16.1 (3.16.0 -> 3.16.1)
    • PR 55 (Tom Aldcroft): Stop showing source code in public docs
  • proseco: 5.15.0 -> 5.16.0 (5.15.0 -> 5.16.0)
    • PR 403 (Jean Connelly): Change dyn_bgd_n_faint default to 2 and fix faint force-include bug
  • sparkles: 4.27.1 -> 4.28.0 (4.27.1 -> 4.28.0)
    • PR 219 (Jean Connelly): Update dec98_9 roll tests with new guide counts
    • PR 217 (Jean Connelly): Ruff: noqa an instance of PLC0206 in a yoshi test
    • PR 215 (Jean Connelly): Apply dynamic background bonus to rolled "n_stars"
    • PR 214 (Jean Connelly): Update a few tests to use old dyn_bgd_n_faint=0 default

Related Issues

Fixes #1437
Fixes #1438
Fixes #1439
Fixes #1440
Fixes #1441
Fixes #1442
Fixes #1443
Fixes #1444
Fixes #1445
Fixes #1446
Fixes #1447
Fixes #1448
Fixes #1449

@javierggt javierggt added this to the 2024.12 milestone Dec 9, 2024
@javierggt javierggt requested a review from jeanconn December 10, 2024 17:24
@javierggt javierggt merged commit 5ce2433 into master Dec 16, 2024
14 of 16 checks passed
@javierggt javierggt deleted the 2024.12-branch branch December 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment