Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bright limit check to use 5.2 mag #162

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Update bright limit check to use 5.2 mag #162

merged 1 commit into from
Sep 22, 2021

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Sep 9, 2021

Description

Update bright limit check to use 5.2 mag

Testing

  • Passes unit tests on linux
  • Functional testing - updated unit test is a functional test

@jeanconn jeanconn requested a review from taldcroft September 20, 2021 17:10
taldcroft
taldcroft approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeanconn jeanconn merged commit f1c31dc into master Sep 22, 2021
@jeanconn jeanconn deleted the bright-5p2 branch September 22, 2021 17:11
@jeanconn
Copy link
Contributor Author

I forgot this test won't pass until sot/proseco#368 goes in to update the star selection.

This was referenced Oct 25, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
@javierggt javierggt mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft