Update tests for proseco p2 overlap change

[jeanconn]

Description

Update tests for proseco p2 overlap change (in sot/proseco#394)

Fixes the issue that environments with that updated overlap-p2 proseco version see this in the tests

(ska3-masters) jeanconn-fido> pytest 
================================================================================= test session starts =================================================================================
platform linux -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 103 items                                                                                                                                                                   

sparkles/tests/test_checks.py .......................................................................FF...                                                                      [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                                    [ 78%]
sparkles/tests/test_review.py ..................                                                                                                                                [ 96%]
sparkles/tests/test_yoshi.py F...                                                                                                                                               [100%]

====================================================================================== FAILURES
...

Interface impacts

Testing

Unit tests

• Linux

(ska3-masters) jeanconn-fido> pytest 
================================================================================= test session starts =================================================================================
platform linux -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 103 items                                                                                                                                                                   

sparkles/tests/test_checks.py ............................................................................                                                                      [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                                    [ 78%]
sparkles/tests/test_review.py ..................                                                                                                                                [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                                               [100%]

=========================================================================== 103 passed in 85.72s (0:01:25) ============================================================================
(ska3-masters) jeanconn-fido> git rev-parse HEAD
ceccd8e712cbad4dfffede231222efdcebafe8b3

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

No functional testing.

[jeanconn]

I was not immediately anticipating that guide-related test would change, but these guide indexes are the overall catalog idx values, and acquisition-related changes fiddle with order of BOT stars in the list. I confirmed that these are the same 3 stars.