Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic background (dyn_bgd_n_faint) test fixes #218

Closed
wants to merge 2 commits into from

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Nov 26, 2024

Description

Update more tests related to the dyn_bgd_n_faint default change from 0 to 2.

These should have all been fixed in #214 and the test process there looks reasonable. Yet the tests were failing when I reran unit tests now and seemed related to the dyn_bgd_n_faint change.
I am puzzled but these additional changes seem benign and get tests to pass.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-latest) flame:sparkles jean$ python -c "import proseco; print(proseco.__version__)"
5.15.1.dev6+g23db6ec
(ska3-flight-latest) flame:sparkles jean$ git rev-parse HEAD
36d1b9bf8cf710ea092290d8178d2b1f17eadf4e
(ska3-flight-latest) flame:sparkles jean$ pytest
======================================================================= test session starts =======================================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
PyQt5 5.15.9 -- Qt runtime 5.15.8 -- Qt compiled 5.15.8
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, qt-4.4.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 103 items                                                                                                                                               

sparkles/tests/test_checks.py ............................................................................                                                  [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                [ 78%]
sparkles/tests/test_review.py ..................                                                                                                            [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                           [100%]

====================================================================== 103 passed in 29.28s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn changed the base branch from master to ruff-plc0206 November 26, 2024 14:49
Base automatically changed from ruff-plc0206 to master November 26, 2024 14:50
@jeanconn
Copy link
Contributor Author

Nah. I think I just had an issue with my local git repo.

@jeanconn jeanconn closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant