Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of test(get_version=True) for versioning #89

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

taldcroft
Copy link
Member

This passes unit tests. I confirmed that running on a pickle file from JAN2819 and generating a review report shows the expected version numbers.

Fixes #88.

I'm basing this on 4.1.x. Once reviewed and merged we can cherry-pick into master. Traditionally it goes the other way around, but getting this in 4.1.x first is probably the priority.

@taldcroft taldcroft added this to the 4.1 milestone Feb 26, 2019
@taldcroft taldcroft requested a review from jeanconn February 26, 2019 17:01
@jeanconn
Copy link
Contributor

And since master and 4.1.x should be the same, we should be OK regardless.

Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me.

@taldcroft taldcroft merged commit 68ac502 into 4.1.x Feb 26, 2019
@taldcroft taldcroft deleted the no-test-version branch February 26, 2019 17:17
taldcroft added a commit that referenced this pull request Feb 26, 2019
Remove use of test(get_version=True) for versioning
@taldcroft
Copy link
Member Author

For the record I just cherry-picked this into master:

$ get checkout master
$ git cherry-pick -m 1  68ac502
$ git diff master 4.1.x
  <no diff>
$ git push origin master

That generated 4dfc3e6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants