Remove some useless ACQ star warnings (#437)

* Remove some useless ACQ star warnings * Remove Acq star implication of ACA-041
sot · Feb 9, 2024 · 9feb420 · 9feb420
1 parent 20b7c0a
commit 9feb420
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/starcheck/src/aca_load_review_cl.rst b/starcheck/src/aca_load_review_cl.rst
@@ -302,10 +302,7 @@ Checks
 |ACA-040|Monitor commanding|X|X|Dither is disabled and enabled with correct|n/a |Failure to track|
 |       |                  | | |timing                                     |    |                |
 +-------+------------------+-+-+-------------------------------------------+----+----------------+
-|       |                  |X|X|                                           |    |AS: Reduced     |
-|       |                  | | |                                           |    |acq probability |
-|       |                  | | |                                           |    |of star         |
-|ACA-041|Magnitude         | | |Slot MAXMAG (faint limit) - star MAG >= 0.3|n/a |GS: Increased   |
+|ACA-041|Magnitude         |X|X|Slot MAXMAG (faint limit) - star MAG >= 0.3|n/a |GS: Increased   |
 |       |                  | | |                                           |    |risk of loss of |
 |       |                  | | |                                           |    |track of star   |
 +-------+------------------+-+-+-------------------------------------------+----+----------------+

diff --git a/starcheck/src/lib/Ska/Starcheck/Obsid.pm b/starcheck/src/lib/Ska/Starcheck/Obsid.pm
@@ -1482,9 +1482,7 @@ sub check_star_catalog {
             push @orange_warn, sprintf "[%2d] Acq Off (padded) CCD by > 60 arcsec.\n",
               $i;
         }
-        elsif (($type =~ /BOT|ACQ/) and ($acq_edge_delta < 0)) {
-            push @{ $self->{fyi} }, sprintf "[%2d] Acq Off (padded) CCD\n", $i;
-        }
+
 
         # Faint and bright limits ~ACA-009 ACA-010
         if ($mag ne '---') {
@@ -1501,12 +1499,6 @@ sub check_star_catalog {
                 if ($mag < 5.2) {
                     push @warn, $acq_mag_warn;
                 }
-                elsif ($mag > $self->{mag_faint_red}) {
-                    push @orange_warn, $acq_mag_warn;
-                }
-                elsif ($mag > $self->{mag_faint_yellow}) {
-                    push @yellow_warn, $acq_mag_warn;
-                }
             }
         }
 
@@ -1543,7 +1535,7 @@ sub check_star_catalog {
             }
         }
 
-        if ($type =~ /BOT|GUI|ACQ/) {
+        if ($type =~ /BOT|GUI/) {
             if (($maxmag =~ /---/) or ($mag =~ /---/)) {
                 push @warn, sprintf "[%2d] Magnitude.  MAG or MAGMAX not defined \n",
                   $i;