-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proseco for a quasi-independent hot pix check #276
+115
−254
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
138043d
Use proseco for a quasi-independent hot pix check
jeanconn c296d56
Set hot pix check to work with fid lights
jeanconn 65d5f6d
Add a docstring for check_hot_pix
jeanconn 28fda24
Update check_hot_pix for style
jeanconn f8314a1
Use different offset lims for hot pix warns
jeanconn 798aac4
Handle get_imposter_mags errors without crashing
jeanconn c313ffa
Remove some unneeded input casts in check_hot_pix
jeanconn 27d9b4c
Prepend 'centroid' to 'offset' in imposter warning
jeanconn 7378ad1
Remove more cruft in check_hot_pix
jeanconn 48c16bc
Update warning format for Imposters
jeanconn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,255 +1,3 @@ | ||
| Bad Pixel List from 2017272 2018002 2018100 Dark Currents | ||
|
|
||
| Star.Body.Pixels.BadPixels = [ ... | ||
| -512, 511, -1, 0; ... | ||
| -1, 0, -512, 511; ... | ||
| -245, 0, 454, 454; ... | ||
| -511, -511, 9, 9; ... | ||
| -510, -510, -289, -289; ... | ||
| -510, -510, 158, 158; ... | ||
| -510, -510, 445, 445; ... | ||
| -509, -509, -194, -194; ... | ||
| -506, -506, 150, 150; ... | ||
| -497, -497, -366, -366; ... | ||
| -495, -495, 207, 207; ... | ||
| -491, -491, -435, -435; ... | ||
| -480, -480, -427, -427; ... | ||
| -476, -476, 83, 83; ... | ||
| -464, -464, -341, -341; ... | ||
| -464, -464, -96, -96; ... | ||
| -461, -461, -445, -445; ... | ||
| -461, -461, 292, 292; ... | ||
| -457, -457, -14, -14; ... | ||
| -451, -451, 380, 380; ... | ||
| -449, -449, 268, 268; ... | ||
| -447, -447, 244, 244; ... | ||
| -443, -443, -64, -64; ... | ||
| -441, -441, 86, 86; ... | ||
| -426, -426, -159, -159; ... | ||
| -417, -417, 474, 474; ... | ||
| -416, -416, -40, -40; ... | ||
| -415, -415, 28, 28; ... | ||
| -414, -414, -42, -42; ... | ||
| -411, -411, 22, 22; ... | ||
| -405, -405, -179, -179; ... | ||
| -395, -395, 462, 462; ... | ||
| -390, -390, -371, -371; ... | ||
| -390, -390, -335, -335; ... | ||
| -390, -390, 90, 90; ... | ||
| -383, -383, -247, -247; ... | ||
| -382, -382, 328, 328; ... | ||
| -381, -381, -247, -247; ... | ||
| -375, -375, -403, -403; ... | ||
| -372, -372, -50, -50; ... | ||
| -372, -372, -40, -40; ... | ||
| -370, -370, 126, 126; ... | ||
| -364, -364, -229, -229; ... | ||
| -364, -364, 249, 249; ... | ||
| -359, -359, 409, 409; ... | ||
| -355, -355, -132, -132; ... | ||
| -354, -354, 387, 387; ... | ||
| -353, -353, -486, -486; ... | ||
| -353, -353, -422, -422; ... | ||
| -352, -352, 226, 226; ... | ||
| -347, -347, 29, 29; ... | ||
| -338, -338, -60, -60; ... | ||
| -333, -333, 16, 16; ... | ||
| -333, -333, 387, 387; ... | ||
| -316, -316, -46, -46; ... | ||
| -311, -311, -329, -329; ... | ||
| -302, -302, 237, 237; ... | ||
| -301, -301, 391, 391; ... | ||
| -297, -297, 421, 421; ... | ||
| -296, -296, -459, -459; ... | ||
| -295, -295, -311, -311; ... | ||
| -286, -286, 350, 350; ... | ||
| -283, -283, -315, -315; ... | ||
| -281, -281, -358, -358; ... | ||
| -272, -272, -12, -12; ... | ||
| -267, -267, -325, -325; ... | ||
| -265, -265, 466, 466; ... | ||
| -260, -260, -24, -24; ... | ||
| -259, -259, 59, 59; ... | ||
| -259, -259, 122, 122; ... | ||
| -258, -258, -491, -491; ... | ||
| -255, -255, -251, -251; ... | ||
| -252, -252, -485, -485; ... | ||
| -252, -252, -120, -120; ... | ||
| -252, -252, 32, 32; ... | ||
| -241, -241, -416, -416; ... | ||
| -238, -238, 93, 93; ... | ||
| -235, -235, -158, -158; ... | ||
| -231, -231, -399, -399; ... | ||
| -231, -231, 487, 487; ... | ||
| -220, -220, 438, 438; ... | ||
| -217, -217, 207, 207; ... | ||
| -215, -215, -414, -414; ... | ||
| -214, -214, -296, -296; ... | ||
| -213, -213, 340, 340; ... | ||
| -210, -210, -351, -351; ... | ||
| -200, -200, 392, 392; ... | ||
| -196, -196, 38, 38; ... | ||
| -195, -195, 304, 304; ... | ||
| -194, -194, -314, -314; ... | ||
| -191, -191, -326, -326; ... | ||
| -186, -186, -365, -365; ... | ||
| -174, -174, -84, -84; ... | ||
| -174, -174, 367, 367; ... | ||
| -161, -161, 150, 150; ... | ||
| -157, -157, -267, -267; ... | ||
| -154, -154, -200, -200; ... | ||
| -152, -152, -413, -413; ... | ||
| -145, -145, 159, 159; ... | ||
| -144, -144, -80, -80; ... | ||
| -142, -142, 236, 236; ... | ||
| -137, -137, 98, 98; ... | ||
| -126, -126, 85, 85; ... | ||
| -123, -123, 133, 133; ... | ||
| -122, -122, -267, -267; ... | ||
| -111, -111, 381, 381; ... | ||
| -108, -108, 441, 441; ... | ||
| -103, -103, -234, -234; ... | ||
| -100, -100, 229, 229; ... | ||
| -100, -100, 470, 470; ... | ||
| -99, -99, 362, 362; ... | ||
| -98, -98, 106, 106; ... | ||
| -98, -98, 377, 377; ... | ||
| -97, -97, -321, -321; ... | ||
| -96, -96, -119, -119; ... | ||
| -92, -92, 214, 214; ... | ||
| -85, -85, 170, 170; ... | ||
| -83, -83, -432, -432; ... | ||
| -83, -83, -3, -3; ... | ||
| -64, -64, -83, -83; ... | ||
| -63, -63, -174, -174; ... | ||
| -62, -62, -212, -212; ... | ||
| -56, -56, -325, -325; ... | ||
| -56, -56, 164, 164; ... | ||
| -47, -47, 180, 180; ... | ||
| -44, -44, -478, -478; ... | ||
| -42, -42, 11, 11; ... | ||
| -39, -39, -205, -205; ... | ||
| -35, -35, 408, 408; ... | ||
| -34, -34, 423, 423; ... | ||
| -31, -31, -342, -342; ... | ||
| -20, -20, -493, -493; ... | ||
| -10, -10, 93, 93; ... | ||
| -8, -8, 458, 458; ... | ||
| -2, -2, 211, 211; ... | ||
| 1, 1, -424, -424; ... | ||
| 1, 1, -156, -156; ... | ||
| 2, 2, 382, 382; ... | ||
| 10, 10, 299, 299; ... | ||
| 12, 12, -68, -68; ... | ||
| 19, 19, 314, 314; ... | ||
| 25, 25, 108, 108; ... | ||
| 25, 25, 111, 111; ... | ||
| 27, 27, -204, -204; ... | ||
| 28, 28, 440, 440; ... | ||
| 40, 40, -332, -332; ... | ||
| 45, 45, 174, 174; ... | ||
| 46, 46, 136, 136; ... | ||
| 47, 47, 97, 97; ... | ||
| 57, 57, -228, -228; ... | ||
| 68, 68, -301, -301; ... | ||
| 92, 92, 326, 326; ... | ||
| 101, 101, -250, -250; ... | ||
| 114, 114, 340, 340; ... | ||
| 122, 122, -433, -433; ... | ||
| 126, 126, -328, -328; ... | ||
| 126, 126, -29, -29; ... | ||
| 128, 128, -461, -461; ... | ||
| 130, 130, 249, 249; ... | ||
| 131, 131, 127, 127; ... | ||
| 132, 132, -344, -344; ... | ||
| 134, 134, -3, -3; ... | ||
| 137, 137, -452, -452; ... | ||
| 138, 138, 9, 9; ... | ||
| 139, 139, -140, -140; ... | ||
| 139, 139, 309, 309; ... | ||
| 141, 141, 61, 61; ... | ||
| 142, 142, 254, 254; ... | ||
| 143, 143, -209, -209; ... | ||
| 144, 144, 226, 226; ... | ||
| 148, 148, 26, 26; ... | ||
| 149, 149, 508, 508; ... | ||
| 152, 152, 496, 496; ... | ||
| 155, 155, 151, 151; ... | ||
| 158, 158, -463, -463; ... | ||
| 160, 160, 86, 86; ... | ||
| 162, 162, -355, -355; ... | ||
| 162, 162, -203, -203; ... | ||
| 165, 165, -240, -240; ... | ||
| 171, 171, -362, -362; ... | ||
| 174, 174, 261, 261; ... | ||
| 186, 186, -491, -491; ... | ||
| 192, 192, 211, 211; ... | ||
| 193, 193, -246, -246; ... | ||
| 199, 199, -412, -412; ... | ||
| 203, 203, -452, -452; ... | ||
| 214, 214, -26, -26; ... | ||
| 223, 223, 402, 402; ... | ||
| 226, 226, 110, 110; ... | ||
| 228, 228, -29, -29; ... | ||
| 229, 229, -495, -495; ... | ||
| 230, 230, 26, 26; ... | ||
| 246, 246, 338, 338; ... | ||
| 247, 247, -350, -350; ... | ||
| 252, 252, -254, -254; ... | ||
| 253, 253, -365, -365; ... | ||
| 256, 256, -62, -62; ... | ||
| 269, 269, 330, 330; ... | ||
| 270, 270, -333, -333; ... | ||
| 271, 271, 272, 272; ... | ||
| 274, 274, -427, -427; ... | ||
| 281, 281, 241, 241; ... | ||
| 285, 285, 99, 99; ... | ||
| 286, 286, 127, 127; ... | ||
| 289, 289, -409, -409; ... | ||
| 293, 293, -150, -150; ... | ||
| 294, 294, -438, -438; ... | ||
| 309, 309, -342, -342; ... | ||
| 315, 315, -174, -174; ... | ||
| 319, 319, -512, -512; ... | ||
| 320, 320, 190, 190; ... | ||
| 321, 321, -416, -416; ... | ||
| 321, 321, 361, 361; ... | ||
| 324, 324, -18, -18; ... | ||
| 326, 326, 12, 12; ... | ||
| 330, 330, 390, 390; ... | ||
| 337, 337, 43, 43; ... | ||
| 342, 342, -281, -281; ... | ||
| 342, 342, 6, 6; ... | ||
| 349, 349, 369, 369; ... | ||
| 358, 358, 419, 419; ... | ||
| 364, 364, -303, -303; ... | ||
| 369, 369, 184, 184; ... | ||
| 372, 372, 379, 379; ... | ||
| 374, 374, -419, -419; ... | ||
| 374, 374, -95, -95; ... | ||
| 379, 379, 279, 279; ... | ||
| 385, 385, -506, -506; ... | ||
| 392, 392, -32, -32; ... | ||
| 393, 393, 254, 254; ... | ||
| 394, 394, -323, -323; ... | ||
| 396, 396, 283, 283; ... | ||
| 418, 418, -505, -505; ... | ||
| 422, 422, -1, -1; ... | ||
| 427, 427, 38, 38; ... | ||
| 431, 431, 300, 300; ... | ||
| 437, 437, -262, -262; ... | ||
| 440, 440, 5, 5; ... | ||
| 443, 443, -416, -416; ... | ||
| 446, 446, 305, 305; ... | ||
| 456, 456, 466, 466; ... | ||
| 461, 461, -199, -199; ... | ||
| 465, 465, -242, -242; ... | ||
| 476, 476, 403, 403; ... | ||
| 477, 477, -6, -6; ... | ||
| 491, 491, -266, -266; ... | ||
| 493, 493, 113, 113; ... | ||
| 494, 494, -209, -209; ... | ||
| 501, 501, -367, -367; ... | ||
| 507, 507, 49, 49; ... | ||
| 508, 508, 349, 349; ... | ||
| ]; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent here is that only the large CCD trap remains (not sure if the fid defect should be added).
Functionally I just checked that an observation that previously had a star with a trap-related warning still did so with this bad pixel list. Obsid 48812 in OCT2918A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not add a comment in the file about the trap as I didn't want to play games with the parser.