Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check observations prior to schedule start (DOT) #281

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jan 15, 2019

This skips starcheck checking of backstop commands which occur prior to the formal schedule start.

This applies to replan/reopen products where backstop commanding from a prior schedule is included in the command loads but was not generated in the schedule. The implementation relies on the DOT to define commands which are subject to starcheck review.

See the icxc aspect area tmp/jan0419a.html for an example output. The global command warnings remain, along with the dynamic offsets errors due to obsids that are missing from the OR list.

Closes #101

@taldcroft taldcroft requested a review from jeanconn January 15, 2019 12:19
@taldcroft taldcroft added this to the 13.0 proseco milestone Jan 15, 2019
@jeanconn
Copy link
Contributor

This is great! But I'm trying to remember what to test for some of the weird stuff and/or what our requirements are. For example I thought thought there was some obsid fudging in some types of observations in vehicle-only products? But I can't quite remember.

@jeanconn
Copy link
Contributor

Also, do you want me to remove an changes in #272 that are unnecessary combined with this change?

@taldcroft
Copy link
Member Author

Also, do you want me to remove an changes in #272 that are unnecessary combined with this change?

Yes. Probably makes sense for you to review / test this PR until you are satisfied, merge, then rebase #272 and remove changes in #272 that become unnecessary.

@jeanconn
Copy link
Contributor

I'm still not sure if I should find any really weird things to throw at this, but it looks fine to me in regression testing and the code changes, so moving forward.

@jeanconn jeanconn merged commit ab51840 into master Jan 16, 2019
@jeanconn jeanconn deleted the reopen branch January 16, 2019 12:45
@jeanconn
Copy link
Contributor

Though as you noted at top, the warnings on the dynamic aimpoint checks remain which, from a public perspective, does mean that starcheck's output isn't strictly starting at schedule start.

@taldcroft
Copy link
Member Author

This is carried over to #287 now for the dynamic aimpoints checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants