Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACA model spec for shiny #349

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Update ACA model spec for shiny #349

merged 1 commit into from
Aug 17, 2020

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Aug 1, 2020

Description

Change the epoch time to use a fully-qualified date string. This uses the same aca_spec.json file that was approved at TWG.

Testing

  • [N/A] Passes unit tests
  • Functional testing

Functional testing

Using this branch and the current ska3-flight environment on kady:

./sandbox_starcheck -dir ~/ska/data/mpcrit1/mplogs/2020/JUL2020/ofls -out JUL2020-test -run_start_time '2020-07-15T14:11:29'

Using the master branch and ska3-flight on kady:

./sandbox_starcheck -dir ~/ska/data/mpcrit1/mplogs/2020/JUL2020/ofls -out JUL2020-master -run_start_time '2020-07-15T14:11:29'

Review outputs were identical, in particular the text version of the review page and the ccd_temperature.png plot file.

Interface impacts

None

Deployment

This will be installed with the Ska3-shiny distribution.

@taldcroft taldcroft requested a review from jeanconn August 12, 2020 10:39
@taldcroft taldcroft merged commit 65d9fc7 into master Aug 17, 2020
@taldcroft taldcroft deleted the epoch-for-shiny branch August 17, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants