Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info statement regarding being off padded CCD #358

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

taldcroft
Copy link
Member

Description

The statement that P_ACQ should be less than 0.5 was misleading.

Testing

No testing done since this is just changing the text of a message.

  • [N/A] Passes unit tests on MacOS, linux, Windows (at least one required)
  • [N/A] Functional testing

The statement that P_ACQ should be less than 0.5 was misleading.
@jeanconn
Copy link
Contributor

jeanconn commented Nov 5, 2020

This change doesn't bother me. I was planning to chuck it altogether in #327. I suppose I was also hesitant to cut a starcheck release before shiny with the thought that briefing any changes to load review tools in the context of shiny promotion was not ideal.

@taldcroft
Copy link
Member Author

I don't care if this gets merged or promoted any time soon, I just wanted to do the PR while it was on my mind.

@jeanconn
Copy link
Contributor

jeanconn commented Nov 5, 2020

OK. Then I'm good to merge it now.

@jeanconn jeanconn merged commit fc7dfcb into master Nov 5, 2020
@jeanconn jeanconn deleted the taldcroft-patch-1 branch November 5, 2020 20:05
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants