Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recharacterize too few guide warning as yellow warn #365

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Recharacterize too few guide warning as yellow warn #365

merged 1 commit into from
Jan 13, 2021

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jan 10, 2021 •
edited
Loading

Description

Recharacterize too few guide warning as yellow warn

This changes a red warning on too few commanded guide stars to a yellow warning. The guide count will be the limiting/red check in these cases. I don't think this needs a load review checklist update (it notes requirements >= 4 and standard configuration = 5).

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
    • No unit tests
  • Functional testing
    • Ran on DEC0720 and confirmed critical ">> CRITICAL: Only 4 Guide Stars (5 required)" is now a CAUTION

Fixes #

@jeanconn jeanconn requested a review from taldcroft January 11, 2021 17:19
@jeanconn jeanconn merged commit 5df731b into master Jan 13, 2021
@jeanconn jeanconn deleted the change_guide_warn branch January 13, 2021 13:41
This was referenced Apr 2, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request Apr 12, 2021
Closed
@javierggt javierggt mentioned this pull request Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft