Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the bright limit to 5.2 in code and checklist #377

Merged
merged 3 commits into from
Oct 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions starcheck/src/aca_load_review_cl.rst
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,10 @@ Checks
| | | | |configuration (2 | | | | | | |
| | | | |monitor windows) | | | | | | |
+-------+------------------+-+-+--------------------+------+-----+----+----+----+----------------+
|ACA-009|Magnitude limit |X|X|AS: 5.8 - 10.3 (or fainter, if needed to |n/a |Possible Bright |
|ACA-009|Magnitude limit |X|X|AS: 5.2 - 10.3 (or fainter, if needed to |n/a |Possible Bright |
| | | | |find stars) | |Star Hold |
+-------+------------------+-+-+-------------------------------------------+----+----------------+
|ACA-010|Magnitude limit |X|X|GS: 6.0 - 10.3 (or fainter, if needed to |n/a |Reduced aspect |
|ACA-010|Magnitude limit |X|X|GS: 5.2 - 10.3 (or fainter, if needed to |n/a |Reduced aspect |
| | | | |find stars) | |quality |
+-------+------------------+-+-+-------------------------------------------+----+----------------+
|ACA-011|Magnitude limit |X|X|FL: 6.8 - 7.2 |n/a |Reduced aspect |
Expand Down
4 changes: 2 additions & 2 deletions starcheck/src/lib/Ska/Starcheck/Obsid.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1524,13 +1524,13 @@ sub check_star_catalog {
if ($mag ne '---') {
if ($type eq 'GUI' or $type eq 'BOT'){
my $guide_mag_warn = sprintf "[%2d] Magnitude. Guide star %6.3f\n", $i, $mag;
if (($mag > 10.3) or ($mag < 6.0)){
if (($mag > 10.3) or ($mag < 5.2)){
push @warn, $guide_mag_warn;
}
}
if ($type eq 'BOT' or $type eq 'ACQ'){
my $acq_mag_warn = sprintf "[%2d] Magnitude. Acq star %6.3f\n", $i, $mag;
if ($mag < 5.8){
if ($mag < 5.2){
push @warn, $acq_mag_warn;
}
elsif ($mag > $self->{mag_faint_red}){
Expand Down