Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starcheck IR zone to (-5, +35) #447

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update starcheck IR zone to (-5, +35) #447

merged 1 commit into from
Sep 27, 2024

Conversation

jeanconn
Copy link
Contributor

Description

Update starcheck IR zone to (-5, +35)

Fixes #446

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-latest) flame:starcheck jean$ pytest
=========================================================== test session starts ============================================================
platform darwin -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 14 items                                                                                                                         

starcheck/tests/test_state_checks.py .............                                                                                   [ 92%]
starcheck/tests/test_utils.py .                                                                                                      [100%]

============================================================ 14 passed in 5.96s ============================================================
(ska3-flight-latest) flame:starcheck jean$ git rev-parse HEAD
7277f052424ad62b8e080ca2353c13f7185b566b

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@jeanconn jeanconn merged commit 3e3fe21 into master Sep 27, 2024
@jeanconn jeanconn deleted the ir-zone-sep-2025 branch September 27, 2024 15:50
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update starcheck IR zone to (-5, +35)
2 participants