Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check at every dispatcher's bind method #63

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Add null check at every dispatcher's bind method #63

merged 2 commits into from
Nov 4, 2016

Conversation

NikoYuwono
Copy link
Contributor

Fix #62

  • Implement preconditions to make sure lightcycle binding target is not null
  • Add test

glung
glung suggested changes Nov 4, 2016
View reviewed changes
Copy link
Contributor

@glung glung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ! Just one little change and 🚢

lightcycle-lib/src/main/java/com/soundcloud/lightcycle/util/Preconditions.java

/**
* Created by yuwono-niko on 11/4/16.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the header, please ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! It was generated by Android Studio and didn't realize other files don't have any header.

@glung glung merged commit a7dc44b into soundcloud:master Nov 4, 2016
@glung
Copy link
Contributor

glung commented Nov 4, 2016

Thanks. I am going to give you a heads up when releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glung glung glung approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikoYuwono @glung @NikoM3