fix(encrypted-archive): support Node.js v18+ #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argon2-browser does not work with Node.js 18. see antelle/argon2-browser#81 Note: Do not update `argon2`. from `argon2@0.28` we cannot specify less memory size (Maximum "2048" from `0.28.0 - 0.28.2`, maximum "1024" from `>=0.28.3`). The argon2 library must be able to specify a minimum memory size of "8" due to loss of backward compatibility.
…he argon2 library
…argon2 library only on CI
…ater This PR is just a patch. For older versions of Node.js that we have supported so far, we will still use `argon2-browser`.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
packages/encrypted-archive/src/key-derivation-function/argon2.ts
Outdated
Show resolved
Hide resolved
Code Climate reported: + Function `argon2Hash` has 39 lines of code (exceeds 25 allowed). Consider refactoring.
…tion/argon2.ts` file Code Climate reported: + File `argon2.ts` has 281 lines of code (exceeds 250 allowed). Consider refactoring.
ESM does not work well in Jest
…tion/argon2.ts` file Code Climate reported: + File `argon2.ts` has 253 lines of code (exceeds 250 allowed). Consider refactoring.
sounisi5011
force-pushed
the
encrypted-archive/support-node-18
branch
from
2e1eac8
to
a514a73
Compare
|
Code Climate has analyzed commit 7239b88 and detected 0 issues on this pull request. View more on Code Climate. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update that could not be done within #428 because it involves updating dependencies.