-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ All tests that run the CLI should set the COREPACK_HOME
environment variable to use the test-specific Corepack installation directory
#233
Commits on Jul 2, 2023
-
💚 [Debug] Display all errors thrown by the CLI
We need to know why the `npm config get tag-version-prefix` command failing.
Configuration menu - View commit details
-
Copy full SHA for 697081f - Browse repository at this point
Copy the full SHA 697081fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd82128 - Browse repository at this point
Copy the full SHA cd82128View commit details -
💚 [Debug] Run
npm --version
command beforenpm config get ...
com……mand Check to see if the error is caused by the `npm config get ...` command or if npm is throwing an error.
Configuration menu - View commit details
-
Copy full SHA for 81b45bb - Browse repository at this point
Copy the full SHA 81b45bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a227759 - Browse repository at this point
Copy the full SHA a227759View commit details -
⏪ Revert "✅ Disable concurrent running of some tests"
This reverts commit a227759.
Configuration menu - View commit details
-
Copy full SHA for f6d7bd4 - Browse repository at this point
Copy the full SHA f6d7bd4View commit details -
⏪ Revert "💚 [Debug] Run
npm --version
command before `npm config ge……t ...` command" This reverts commit 81b45bb.
Configuration menu - View commit details
-
Copy full SHA for 08745aa - Browse repository at this point
Copy the full SHA 08745aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9630d74 - Browse repository at this point
Copy the full SHA 9630d74View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed9f714 - Browse repository at this point
Copy the full SHA ed9f714View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3473762 - Browse repository at this point
Copy the full SHA 3473762View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9aa566 - Browse repository at this point
Copy the full SHA a9aa566View commit details -
⏪ Revert "✅ Remove unnecessary
npm_*
environment variables when run……ning tests" This reverts commit a9aa566.
Configuration menu - View commit details
-
Copy full SHA for ddfe27b - Browse repository at this point
Copy the full SHA ddfe27bView commit details
Commits on Jul 3, 2023
-
💚 Run the test without using the
task
commandThe `task` command may be the cause of the segmentation fault.
Configuration menu - View commit details
-
Copy full SHA for 1212228 - Browse repository at this point
Copy the full SHA 1212228View commit details -
⏪ Revert "💚 Run the test without using the
task
command"This reverts commit 1212228.
Configuration menu - View commit details
-
Copy full SHA for 1fb8547 - Browse repository at this point
Copy the full SHA 1fb8547View commit details -
✨ Ignore all errors from
npm config get ...
commands executed by th……e `tryNpmConfigGet()` function The `pnpm version` command executes the `npm version` command as is. Therefore, the configuration to be used should be obtained by the `npm config get ...` command. `tryNpmConfigGet()` tries the `npm config get ...` command for this purpose. However, if the `npm config get ...` command fails, we should not force termination there. We should be allowed to use the `pnpm config get ...` command instead.
Configuration menu - View commit details
-
Copy full SHA for 7cee91c - Browse repository at this point
Copy the full SHA 7cee91cView commit details -
⏪ Revert "✨ Ignore all errors from
npm config get ...
commands exec……uted by the `tryNpmConfigGet()` function" This commit fixes the problem of the `npm config get ...` command being aborted by the `SIGSEGV` signal. However, there may be other ways to do this. We are reverting this commit to try them. This reverts commit 7cee91c.
Configuration menu - View commit details
-
Copy full SHA for 26d7361 - Browse repository at this point
Copy the full SHA 26d7361View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14501e5 - Browse repository at this point
Copy the full SHA 14501e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ca0c1 - Browse repository at this point
Copy the full SHA 12ca0c1View commit details -
✅ All
exec()
functions returned by theinitGit()
function should ……use the `COREPACK_HOME` environment variable All CLI and package manager commands executed within `test/index.ts` should use the `COREPACK_HOME` environment variable. To keep this in mind, we modified our test code as follows: + Add the `execDefaultEnv` option to the `initGit()` function. + Add the `COREPACK_HOME` environment variable to the `execDefaultEnv` option of the `initGit()` function called in `test/index.ts`.
Configuration menu - View commit details
-
Copy full SHA for f479280 - Browse repository at this point
Copy the full SHA f479280View commit details -
⏪ Revert "💚 [Debug] Add details to the error thrown by the `execFileA…
…sync()` function" This reverts commit cd82128.
Configuration menu - View commit details
-
Copy full SHA for bf919e7 - Browse repository at this point
Copy the full SHA bf919e7View commit details -
⏪ Revert "💚 [Debug] Display all errors thrown by the CLI"
This reverts commit 697081f.
Configuration menu - View commit details
-
Copy full SHA for d270e29 - Browse repository at this point
Copy the full SHA d270e29View commit details -
⏪ Revert "💩 [Debug] Get details about segmentation faults using the `…
…segfault-handler` package" This reverts commit 14501e5.
Configuration menu - View commit details
-
Copy full SHA for 6b7eef8 - Browse repository at this point
Copy the full SHA 6b7eef8View commit details -
⏪ Revert "✅ All
exec()
functions returned by theinitGit()
functi……on should use the `COREPACK_HOME` environment variable" This reverts commit f479280.
Configuration menu - View commit details
-
Copy full SHA for 5f0bc0d - Browse repository at this point
Copy the full SHA 5f0bc0dView commit details -
⏪ Revert "⏪ Revert "✅ All
exec()
functions returned by the `initGit……()` function should use the `COREPACK_HOME` environment variable"" This reverts commit 5f0bc0d.
Configuration menu - View commit details
-
Copy full SHA for 90cbafc - Browse repository at this point
Copy the full SHA 90cbafcView commit details -
✅ On Windows,
pnpm add <folder>
command fails when using pnpm insta……lled for testing The error is as follows: ``` TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at new NodeError (node:internal/errors:399:5) at validateString (node:internal/validators:163:11) at Object.resolve (node:path:167:9) at ../node_modules/.pnpm/@pnpm+npm-conf@2.0.4/node_modules/@pnpm/npm-conf/lib/defaults.js (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:15236:23) at __require (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:12:50) at ../node_modules/.pnpm/@pnpm+npm-conf@2.0.4/node_modules/@pnpm/npm-conf/index.js (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:15385:21) at __require (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:12:50) at ../config/config/lib/index.js (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:26161:39) at __require (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:12:50) at ../cli/cli-utils/lib/getConfig.js (D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack\pnpm\7.30.5\dist\pnpm.cjs:46134:20) ``` Probably some kind of bug caused by Windows file paths. However, the pnpm versions are the same. The only difference is the directory where pnpm is installed (`D:\a\package-version-git-tag\package-version-git-tag\test\.temp\.corepack` is defined in the `COREPACK_HOME` environment variable). So I am not sure what kind of bug it is.
Configuration menu - View commit details
-
Copy full SHA for 729f1fd - Browse repository at this point
Copy the full SHA 729f1fdView commit details -
⏪ Revert "✅ On Windows,
pnpm add <folder>
command fails when using ……pnpm installed for testing" This reverts commit 729f1fd.
Configuration menu - View commit details
-
Copy full SHA for 9af05b3 - Browse repository at this point
Copy the full SHA 9af05b3View commit details -
✅ Fix again problem with "pnpm add" commands failing on Windows
Configuration menu - View commit details
-
Copy full SHA for 333c03c - Browse repository at this point
Copy the full SHA 333c03cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c11a224 - Browse repository at this point
Copy the full SHA c11a224View commit details