refactor: Refactor grading related functions to use atoms #1579
Triggered via pull request
September 18, 2024 09:58
GabrielCWT
Status
Success
Total duration
3m 40s
Artifacts
–
Annotations
20 warnings
|
Run CI:
lib/cadet/assessments/assessments.ex#L919
variable "team" is unused (if the variable is not meant to be used, prefix it with an underscore)
|
|
Run CI:
lib/cadet/assessments/assessments.ex#L2657
variable "cr_id" is unused (if the variable is not meant to be used, prefix it with an underscore)
|
|
Run CI
router paths should begin with a forward slash, got: ""
|
|
Run CI:
lib/cadet_web/controllers/answer_controller.ex#L82
clauses with the same name and arity (number of arguments) should be grouped together, "def submit/2" was previously defined (lib/cadet_web/controllers/answer_controller.ex:12)
|
|
Run CI:
lib/cadet/accounts/teams.ex#L47
variable "student_ids" is unused (if the variable is not meant to be used, prefix it with an underscore)
|
|
Run CI:
lib/cadet/accounts/teams.ex#L88
variable "all_ids_distinct" is unused (if the variable is not meant to be used, prefix it with an underscore)
|
|
Run CI:
lib/cadet/accounts/teams.ex#L70
defp student_already_assigned?/2 is private, @doc attribute is always discarded for private functions/macros/types
|
|
Run CI:
lib/cadet/accounts/teams.ex#L94
defp all_students_distinct?/1 is private, @doc attribute is always discarded for private functions/macros/types
|
|
Run CI:
lib/cadet/accounts/teams.ex#L119
defp all_team_within_max_size?/2 is private, @doc attribute is always discarded for private functions/macros/types
|
|
Run CI:
lib/cadet/accounts/teams.ex#L139
defp all_student_enrolled_in_course?/2 is private, @doc attribute is always discarded for private functions/macros/types
|
|
Run CI
:included_environments option is deprecated. Use :dsn to control whether to send events to Sentry.
|
|
Run CI
CadetWeb.Endpoint.init/2 is deprecated, use config/runtime.exs instead or pass additional options when starting the endpoint in your supervision tree
|
|
Run CI:
test/cadet_web/plug/rate_limiter_test.exs#L25
variable "key" is unused (if the variable is not meant to be used, prefix it with an underscore)
|
|
Run CI:
test/cadet_web/plug/rate_limiter_test.exs#L3
unused import Plug.Conn
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|
|
Run CI
attempting to determine the presence of embed_many field :choices with validate_required/3 or field_missing?/2 which has no effect. You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
|