fix: Fix creation of empty submission for teams

source-academy · Oct 14, 2024 · 8796fb7 · 8796fb7
1 parent de0f910
commit 8796fb7
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/lib/cadet/jobs/autograder/grading_job.ex b/lib/cadet/jobs/autograder/grading_job.ex
@@ -112,23 +112,28 @@ defmodule Cadet.Autograder.GradingJob do
         |> where([_, tm], tm.student_id == ^student_id)
         |> Repo.one()
 
-      if !team do
-        # Student is not in any team
-        # Create new team just for the student
-        team =
-          %Team{}
-          |> Team.changeset(%{
-            assessment_id: assessment.id
+      team =
+        if !team do
+          # Student is not in any team
+          # Create new team just for the student
+          team =
+            %Team{}
+            |> Team.changeset(%{
+              assessment_id: assessment.id
+            })
+            |> Repo.insert!()
+
+          %TeamMember{}
+          |> TeamMember.changeset(%{
+            team_id: team.id,
+            student_id: student_id
           })
           |> Repo.insert!()
 
-        %TeamMember{}
-        |> TeamMember.changeset(%{
-          team_id: team.id,
-          student_id: student_id
-        })
-        |> Repo.insert!()
-      end
+          team
+        else
+          team
+        end
 
       %Submission{}
       |> Submission.changeset(%{