Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with bonus xp #1172

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thortol
Copy link
Contributor

@thortol thortol commented Aug 31, 2024

Description

Resolves #1168, #1170.

Some issues with the code and fixes the bug where autograded assignments do not have bonus xp awarded. The bug is fixed by updating bonus xp when grading is published.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Aug 31, 2024

Coverage Status

coverage: 94.372%. remained the same
when pulling 429aad4 on thortol:fix-issues-with-bonus-xp
into c0d95e9 on source-academy:master.

@thortol thortol marked this pull request as draft August 31, 2024 11:40
@thortol thortol marked this pull request as ready for review September 1, 2024 02:27
lib/cadet/assessments/assessments.ex Outdated Show resolved Hide resolved
lib/cadet/assessments/assessments.ex Outdated Show resolved Hide resolved
@thortol thortol self-assigned this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary logic
3 participants