Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix empty submisisons creation for team assessments #1202

Merged
merged 6 commits into from
Oct 14, 2024
Merged

fix: Fix empty submisisons creation for team assessments #1202

merged 6 commits into from
Oct 14, 2024

Conversation

GabrielCWT
Copy link
Contributor

  • Add migration to include a unique index for (team_id, assessment_id) in submissions
  • Fix logic for creation of empty submissions

@GabrielCWT GabrielCWT self-assigned this Oct 14, 2024
@coveralls
Copy link

coveralls commented Oct 14, 2024 •
edited
Loading

Coverage Status

coverage: 93.78% (-0.2%) from 93.95%
when pulling 4a16415 on GabrielCWT:fix-empty-submisisons
into 945db2c on source-academy:master.

RichDom2185
RichDom2185 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) October 14, 2024 14:24
@RichDom2185 RichDom2185 merged commit d7c147f into source-academy:master Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

@GabrielCWT GabrielCWT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabrielCWT @coveralls @RichDom2185