Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Non-Det Interpreter #1725

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Remove Non-Det Interpreter #1725

wants to merge 16 commits into from

Conversation

leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Oct 9, 2024

Instead of doing the big jump and removing everything at once, I think it might be better if I broke down #1707 into several different PRs.

Will resolve:

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11395502875

Details

  • 22 of 32 (68.75%) changed or added relevant lines in 7 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.4%) to 81.253%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/source/typed/typeParser.ts 12 22 54.55%
Files with Coverage Reduction New Missed Lines %
src/runner/sourceRunner.ts 1 88.24%
src/utils/rttc.ts 1 96.69%
src/parser/source/typed/typeParser.ts 2 47.84%
src/index.ts 3 71.12%
Totals Coverage Status
Change from base Build 11140006313: -0.4%
Covered Lines: 10664
Relevant Lines: 12759

💛 - Coveralls

@RichDom2185 RichDom2185 self-requested a review October 9, 2024 04:32
@RichDom2185
Copy link
Member

Let me know when it's ready for review, thanks!

@leeyi45
Copy link
Contributor Author

leeyi45 commented Oct 9, 2024

Let me know when it's ready for review, thanks!

It is ready for review I guess, if we don't mind the coverage drop

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits :)

eslint.config.mjs Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants