chore(build): skip source generation in import for Jmh #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change turns `bspEnabled := false` for `Jmh` because it involves source generation meaning that when you do a build import it will also do the source generation which we don't want on import. NOTE: That if there is another release of sbt-jmh ever this is done by default not, but not yet released: sbt/sbt-jmh#207.
olafurpg
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change turns
bspEnabled := falseforJmhbecause it involvessource generation meaning that when you do a build import it will also
do the source generation which we don't want on import.
NOTE: That if there is another release of sbt-jmh ever this is done by
default not, but not yet released: sbt/sbt-jmh#207.
Test plan
Tests should just stay green.