-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust bindings: please update protobuf dependency #284
Comments
Btw, after posting this issue I got a strange email about a failed pipeline linking to this. |
Created a PR to delete the job. #285 |
The 3.7.1 version of the protobuf crate code doesn't compile with Rust 1.71.0 (version used in this repo), looking into upgrading that first.
Created a PR for the MSRV update here: stepancheg/rust-protobuf#746 |
The reason for this is that the |
Bump version of scip crate Follow up to sourcegraph/scip#284 Manually verified that SCIP generation works OK for rust-analyzer itself. cc `@RalfJung`
Thanks for doing the dependency bump :) |
Bump version of scip crate Follow up to sourcegraph/scip#284 Manually verified that SCIP generation works OK for rust-analyzer itself. cc `@RalfJung`
stepancheg/rust-protobuf#737 fixes a bug in the protobuf crate where it wouldn't interact properly with build systems that use RUSTC_WRAPPER. This was released as a semver-compatible update (v3.7.1), but this crate pins protobuf to
=3.2.0
(which is quite unusual in Rust), so sadly reverse dependencies can't pick up the new protobuf.Would it be possible to update the protobuf dependency?
This is a blocker for rust-lang/rust#127682.
The text was updated successfully, but these errors were encountered: