Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

WIP Add loading spinner to the management console save action #2103

Closed
wants to merge 1 commit into from

Conversation

chrismwendt
Copy link
Contributor

@chrismwendt chrismwendt commented Feb 1, 2019

This adds a spinner to the save action in the management console.

⚠️ WIP

Resolves https://github.com/sourcegraph/sourcegraph/issues/1822

@chrismwendt
Copy link
Contributor Author

I get this error when running bash serve.sh from cmd/management-console/web:

  /Users/chrismwendt/github.com/sourcegraph/sourcegraph/cmd/management-console/web/src/CriticalConfigEditor.scss:1:1: Cannot resolve dependency '/Users/chrismwendt/github.com/sourcegraph/sourcegraph/cmd/management-console/web/node_modules/@sourcegraph/react-loading-spinner/lib/LoadingSpinner.css' at '/Users/chrismwendt/github.com/sourcegraph/sourcegraph/cmd/management-console/web/node_modules/@sourcegraph/react-loading-spinner/lib/LoadingSpinner.css'
    at Resolver.resolve (/Users/chrismwendt/github.com/sourcegraph/sourcegraph/cmd/management-console/web/node_modules/parcel-bundler/src/Resolver.js:70:17)

It looks like Parcel is saying a file that exists doesn't exist 😕 Any idea why?

dev/Procfile Show resolved Hide resolved
@slimsag
Copy link
Member

slimsag commented Feb 1, 2019

Will take a look locally soon.

@slimsag
Copy link
Member

slimsag commented Feb 1, 2019

Apologies, I ran out of time last night to take a look into this one. Maybe @attfarhan or @ijsnow might have quick ideas about why the import isn't working here?

@ijsnow
Copy link
Contributor

ijsnow commented Feb 1, 2019

Fixed by adding .sassrc (parcel-bundler/parcel#39). Funny that you need config for a zero config bundler!!! :sarcasm-face:

@ijsnow
Copy link
Contributor

ijsnow commented Feb 1, 2019

Wait that didn't fix it actually

@ijsnow
Copy link
Contributor

ijsnow commented Feb 1, 2019

It's possible that @attfarhan fixed this same sort of issue yesterday with bootstrap but I can't remember what the solution was off the top of my head.

@chrismwendt
Copy link
Contributor Author

This won't get into 3.0, so there's less pressure to implement it soon.

@felixfbecker felixfbecker changed the title Add loading spinner to the management console save action WIP Add loading spinner to the management console save action Feb 15, 2019
@nicksnyder nicksnyder deleted the management-console-spinner branch September 30, 2019 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants