This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
WIP Add loading spinner to the management console save action #2103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get this error when running
It looks like Parcel is saying a file that exists doesn't exist 😕 Any idea why? |
slimsag
reviewed
Feb 1, 2019
slimsag
reviewed
Feb 1, 2019
Will take a look locally soon. |
Apologies, I ran out of time last night to take a look into this one. Maybe @attfarhan or @ijsnow might have quick ideas about why the import isn't working here? |
Fixed by adding |
Wait that didn't fix it actually |
ijsnow
force-pushed
the
management-console-spinner
branch
from
February 1, 2019 22:28
e6c492b
to
767540b
Compare
It's possible that @attfarhan fixed this same sort of issue yesterday with bootstrap but I can't remember what the solution was off the top of my head. |
This won't get into 3.0, so there's less pressure to implement it soon. |
felixfbecker
changed the title
Add loading spinner to the management console save action
WIP Add loading spinner to the management console save action
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a spinner to the save action in the management console.
Resolves https://github.com/sourcegraph/sourcegraph/issues/1822