This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend: Use Cloud search for Go import badges #30350
frontend: Use Cloud search for Go import badges #30350
Changes from 2 commits
f0ee7ca
a2af97f
bfd0264
bd4ea9f
12f666e
268b246
b777966
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we might be able to drop this TODO as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that hasn't been done. I'm not sure what the exact steps would be here, so I'll let @slimsag comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this TODO is that once shields.io has official badges for Sourcegraph, then we don't need our own endpoint that serves SVGs (and the
serveRepoBadge
below could just redirect to shields.io directly.)Looks like that PR was merged, so I believe we could do this today if we wanted to. If you search for
Sourcegraph
on https://shields.io/ you'll see it's there:And if you click the URL
/sourcegraph/rrc
it pops up the builder UI:But it seems like that badge design doesn't include the Sourcegraph logo, I guess when we added that customization on our side we never sent a PR to shields.io to add the logo there:
so yeah, idk, would it be nice to fix? maybe. but also maybe not worth the time.