Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish proper test suite for sourcemeta::jsontoolkit::URI #953

Open
tony-go opened this issue Aug 13, 2024 · 6 comments
Open

Establish proper test suite for sourcemeta::jsontoolkit::URI #953

tony-go opened this issue Aug 13, 2024 · 6 comments
Assignees

Comments

@tony-go
Copy link
Contributor

tony-go commented Aug 13, 2024

As much we move forward on #710, we figured out that writing a good tests suit is essential.

We want to have a test suit for RFC3986 URI https://www.rfc-editor.org/rfc/rfc3986! The goal of this issue is to gather every piece of information we could find on the topic.

@tony-go tony-go self-assigned this Aug 13, 2024
@tony-go
Copy link
Contributor Author

tony-go commented Aug 14, 2024

What is your view on the finaly goal @jviotti ?

  • Having a standalone test suite?
    or
  • Enrich our test suite with more cases?

@tony-go
Copy link
Contributor Author

tony-go commented Aug 14, 2024

I would like to share my vision about my previous comment.

I'd rather go for the second option, for two reasons:

  1. We would like to benefit from our research as soon as can, by strengthen our test suite This is by doing a lot research that at some point we could have a fully compliant tests. (That could give, on the end, a standalone suite)
  2. Even if having a fully compliant RFC3986 URI parser is the final goal, we should not forget that we first serve jsontoolkit. What I mean is that if we wait to have a full standalone suite before replacing uriparser, it could take a lot of time as once we finally have it we would like to make it review by fellow engineers...

In a one word my vision is to do a first research, extract all what we can from these, open PR (like this one) and then continue to do research on side while we move forward on critical topics for the project.

@jviotti
Copy link
Member

jviotti commented Aug 14, 2024

@tony-go Sorry if I wasn't clear at the beginning. I indeed meant enriching our test suite with more tests, borrowing test suites from other places. The idea being that if we want to get rid of uriparser, let's have a more comprehensive set of tests (vs the basic ones I had right now) so we make sure we avoid pitfalls on complex areas like parsing or resolution.

@jviotti
Copy link
Member

jviotti commented Aug 14, 2024

@jviotti
Copy link
Member

jviotti commented Aug 14, 2024

I think we can re-adapt many of those rather quickly with some ChatGPT/Claude help :D Then we'll be super confident when doing larger changes on the module, and eventually extracting it into URI Kit.

tony-go added a commit that referenced this issue Aug 14, 2024
Ref #953

---------

Signed-off-by: Tony Gorez <gorez.tony@gmail.com>
@jviotti jviotti changed the title Establish proper test suit for sourcemeta::jsontoolkit::URI Establish proper test suite for sourcemeta::jsontoolkit::URI Aug 14, 2024
tony-go added a commit that referenced this issue Aug 15, 2024
Ref: #953

---------

Signed-off-by: Tony Gorez <gorez.tony@gmail.com>
tony-go added a commit that referenced this issue Aug 16, 2024
Ref: #953

Signed-off-by: Tony Gorez <gorez.tony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants