chore: Bump to GoLang v1.18
#721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
blocked
code quality
|
The upgrade to 1.18 by itself shouldn't be blocked by benchmarks, just the use of Generics, which requires 1.18 is blocked by benchmarks |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Interesting thought, IDK why I think of both synonymously 😆 In that case shall make non-draft. |
shahzadlone
added
the
action/no-benchmark
shahzadlone
force-pushed
the
lone/chore/bump-golang-to-1.18
branch
from
812e51c to
5f174a8
Compare
|
Locally I obtain multiple "File is not |
Linting is clean on my end. Can you let us know how you got those errors? |
|
|
@orpheuslummis I don't get that on my end. It's all clear. |
|
@orpheuslummis What version of the linter are you using? try |
latest version of golangci-ci, but we're using that version in CI so that's not the issue I have |
Makes sense. My preference would be to not do #723 until we enforce the 1.19 gofmt standard (because we will have to do that again in the end before bumping to 1.19 anyways). |
orpheuslummis
approved these changes
Aug 3, 2022
shahzadlone
force-pushed
the
lone/chore/bump-golang-to-1.18
branch
from
5f174a8 to
1f9d887
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
- Resolves sourcenetwork#720 - Description > Bumps Go versions of GitHub Action environment setups. > Bumps Docker image Go version. > Bumps and resolves Linter issues. > Bumps and Updates `go.mod`. - Limitation > A sub-linter was disabled because it lacked support with `v1.18` of Go. Can be easily turned back on if they bump up their support (golangci/golangci-lint#2649). > Despite us bumping to 1.18, we internally ban the use of generics until our benchmarks are fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #720
Description
go.mod.Limitation
v1.18of Go. Can be easily turned back on if they bump up their support (Support of generics golangci/golangci-lint#2649).Tasks
How has this been tested?
Specify the platform(s) on which this was tested: