[MRG] add some search/gather/prefetch columns to enable ANI estimation #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1952 +/- ##
==========================================
+ Coverage 83.25% 91.22% +7.97%
==========================================
Files 126 95 -31
Lines 13989 9710 -4279
Branches 1913 1913
==========================================
- Hits 11646 8858 -2788
+ Misses 2071 580 -1491
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bluegenes
changed the title
|
peeked at this, lookin' good! related issues - |
bluegenes
changed the title
|
if it's ok, can we just merge this and I'll tackle the other issues in a larger PR? Dataclass is looking like a good drop-in replacement of the namedtuples after these changes + will also offer some nice simplification |
|
ended up going for the dataclasses changes in #1955 |
This was referenced Apr 21, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchResult,PrefetchResult,GatherResult. Need these cols for ANI estimation (+ some are helpful for general bookkeeping)namedtuple._fieldsto get fieldnames instead of respecifying