[MRG] add tests for multiple rounds of downsampling in prefetch and gather #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## searchresult-dataclass #1956 +/- ##
=======================================================
Coverage 91.26% 91.26%
=======================================================
Files 95 95
Lines 9786 9786
Branches 1918 1918
=======================================================
Hits 8931 8931
Misses 583 583
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
approved these changes
Apr 16, 2022
bluegenes
added a commit
that referenced
this pull request
Apr 20, 2022
…ing dataclasses (#1955) * add some search/gather/prefetch columns to enable ANI estimation * fix introduced err * init SearchResult dataclass * define generic write_cols * add prefetchresult class, clean up post_init repetitiveness later * clean up * add gatherresult dataclass * rm unused line * upd * init searchresult tests * use query_n_hashes; remove num * add basic gatherresult test * save in progress changes * closer... * closer still... * handle num sketches; clean up unnecessary sig comparison cls * use base classes properly to simplify * add tests for multiple rounds of downsampling in prefetch and gather (#1956) * split sketchcomparison to new file; clean up *Result * add minhash tests * init sketchcomparison tests * test incompatible sketch comparisons * test failing *Results * test num SearchResult * fix calcs for gather * upd with suggestions from code review Co-authored-by: C. Titus Brown <titus@idyll.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR into #1955.
This adds tests for multiple rounds of downsampling in both
sourmash gatherandsourmash prefetch.See comment here in #1955 for motivation.