-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: skipmer improvements #3415
Conversation
CodSpeed Performance ReportMerging #3415 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## try-skipmers #3415 +/- ##
================================================
- Coverage 86.45% 86.38% -0.07%
================================================
Files 137 137
Lines 16141 16155 +14
Branches 2219 2219
================================================
+ Hits 13955 13956 +1
- Misses 1879 1892 +13
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Make skipmers robust, but keep #3395 functional in the meantime.
This PR:
Since this changes the
SeqToHashes
strategy a bit, there's one python test where we now see a different error.Future thoughts:
X
). I guess I'm not entirely sure what happens to those atm...