Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqtohashes errors instead of panic for frame errors #3445

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

bluegenes
Copy link
Contributor

Addresses #3395 (comment)

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.36%. Comparing base (8a0600d) to head (30b524e).
Report is 13 commits behind head on try-skipmers.

Files with missing lines Patch % Lines
src/core/src/ffi/minhash.rs 0.00% 5 Missing ⚠️
src/core/src/signature.rs 76.47% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           try-skipmers    #3445      +/-   ##
================================================
- Coverage         86.44%   86.36%   -0.08%     
================================================
  Files               137      137              
  Lines             16156    16195      +39     
  Branches           2219     2219              
================================================
+ Hits              13966    13987      +21     
- Misses             1883     1901      +18     
  Partials            307      307              
Flag Coverage Δ
hypothesis-py 25.43% <ø> (ø)
python 92.40% <ø> (ø)
rust 62.50% <62.50%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bluegenes bluegenes merged commit e077599 into try-skipmers Dec 20, 2024
42 of 44 checks passed
@bluegenes bluegenes deleted the skipmer-errors branch December 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants