-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate ANI based on a CLI flag #164
Comments
Hi @ctb and @bluegenes I wrote a Rust implementation of the sourmash ANI estimation code many weeks ago but never committed it 3b1c1b8 Just putting it here for now in case it's useful until I can continue the integration later, or maybe someone faster than me will do. The Rust implementation is 712X faster than the original Python implementation. |
not good enough. Do better. 😆 that's awesome! |
nice!!! I was just thinking I needed to write one so I could add ANI into |
Let's coauthor a PR to add this to all commands (I hope you do the testing 😂). |
🤔 |
I am not very skilled at writing tests in sourmash because it requires a broader context that I am not very familiar with. |
Streamlined The benchmark here was a strong motivator for the streamlining work. So yay! comparison benchmark (ANI vs not): #236 (comment) streamlined |
I think incorporating ANI calculation in the branchwater plugin will be very useful. For performance, the code will need to be rewritten in Rust, though.
The text was updated successfully, but these errors were encountered: