Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: refactor sketching utilities #112

Merged
merged 3 commits into from
Oct 8, 2024
Merged

MRG: refactor sketching utilities #112

merged 3 commits into from
Oct 8, 2024

Conversation

bluegenes
Copy link
Collaborator

@bluegenes bluegenes commented Oct 7, 2024

  • refactor for reusability: move all generalized sketch building utils --> utils/buildutils.rs
  • do minor refactoring to use sourmash::encodings::HashFunctions for moltype, created Abund enum.
  • requires MRG: derive Hash for HashFunctions sourmash#3344 to use Hash for sourmash::encodings::HashFunctions

Related:

@bluegenes bluegenes changed the title WIP: refactor sketching utilities MRG: refactor sketching utilities Oct 7, 2024
@bluegenes
Copy link
Collaborator Author

@ctb ready for review. No big changes, mostly just moved existing implementations.

@ctb
Copy link
Contributor

ctb commented Oct 7, 2024

Not sure how to sequence this with sourmash-bio/sourmash#3344 (review), but I think the simplest might be to target latest on sourmash and then before a release of directsketch will cut a new release of sourmash. Seem ok?

Alternatively, can just let it hang for a bit until we release new version of sourmash.

bluegenes added a commit to sourmash-bio/sourmash that referenced this pull request Oct 8, 2024
- derive Hash for HashFunctions, so I can use it over in
sourmash-bio/sourmash_plugin_directsketch#112
@bluegenes
Copy link
Collaborator Author

I'm going to target latest and drop it in main for now so I can put up other PRs off of it. I'm not in a hurry for release - no functionality changes here (or currently planned). But I'll make a draft PR to update to the next sourmash core release.

@bluegenes bluegenes merged commit e3b28ff into main Oct 8, 2024
1 check passed
@bluegenes bluegenes deleted the refactor-sketchutils branch October 8, 2024 01:41
@ctb
Copy link
Contributor

ctb commented Oct 8, 2024

I'm going to target latest and drop it in main for now so I can put up other PRs off of it. I'm not in a hurry for release - no functionality changes here (or currently planned). But I'll make a draft PR to update to the next sourmash core release.

sounds good! we'll be in more of a hurry for a sourmash release over in branchwater once I get the MultiCollection PR figured out ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants