Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Fixes #147

Merged
merged 22 commits into from
Jun 24, 2014
Merged

Major Fixes #147

merged 22 commits into from
Jun 24, 2014

Conversation

tduffield
Copy link
Contributor

  • Binary Installation
    • Added missing dependency resolution for using the binary.
  • Dependency Checks
    • Added docker::dep_check that will take an action if certain dependencies are not met.
    • node[docker][alert_on_error_action] = :fatal will kill the chef run and print the error message.
    • node[docker][alert_on_error_action] = :warn will print the error message but continue with the chef run. There is no guarantee that it will succeed though.
  • KitchenCI
    • Copied MiniTests to ServerSpec Tests
    • Added new platforms (Debian 7.4)
    • Changed provisioner from chef-solo to chef-zero
    • Removed Ubuntu 12.10 because it is not supported by Docker and the Kernel is bad and fails all the tests.
    • Removed tests for the source recipe. The dotcloud/docker repo actually doesn’t build any Go deliverables.
    • I think that the source recipe needs to be completely refactored as the dotcloud/docker repo doesn't actually build anything (according to the output)

@bflad
Copy link
Contributor

bflad commented May 7, 2014

This is huge! I'll take a look at this later today and help get it merged.

* Changed provisioner from chef-solo to chef-zero
* Removed Ubuntu 12.10 because it is not supported by Docker and the Kernel is bad and fails all the tests.
* Removed tests for the source recipe. The dotcloud/docker repo actually doesn’t build any Go deliverables.
* I think that the source recipe needs to be completely refactored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely. I haven't really touched the source recipe since Docker 0.1 came out.

@bflad
Copy link
Contributor

bflad commented May 7, 2014

Okay I've quickly gone though everything and its awesome. For the few adjustments I've mentioned, do you want me to handle the rebase and changes? Thanks again!

@tduffield
Copy link
Contributor Author

If you could handle those that would be great. part of the reason that I submitted this pass PR was because I got distracted by something else and wanted to make sure you got them.

@bflad
Copy link
Contributor

bflad commented May 7, 2014

Absolutely, just didn't want to duplicate effort. I really appreciate this and should be able to get it in today or tomorrow.

@someara
Copy link
Contributor

someara commented May 20, 2014

waiting for this to be merged before I get my hands dirty in dockerland =)

Tom Duffield added 3 commits June 4, 2014 09:38
@bflad
Copy link
Contributor

bflad commented Jun 24, 2014

After a long personal hiatus, I'm back to working on this. Sorry everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants