Fix proxy behavior #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy is not actually honored in the current template
|
How does this relate to #1 (comment) ? |
|
In my testing on Ubuntu 12.04, proxy behavior wasn't honored using "env" but switching to export fixed it. That's because env doesn't set variables in a way where it is available to future commands. example: The HTTPS_PROXY line is optional and may be unnecessary. |
|
Hi Brian, I've removed the extraneous line from the pull request. Now it's merely a one-word change ( s/env/export/). OK to commit? |
|
Sorry for the delay here. I'll merge this in and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy is not actually honored in the current template