-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systemd support (working) #59
Commits on Oct 16, 2014
-
Configuration menu - View commit details
-
Copy full SHA for b6f908e - Browse repository at this point
Copy the full SHA b6f908eView commit details -
Convert _ALL_ configuration attributes to a flat namespace
Oh this is just the beginning. FULL SPEED AHEAD!
Configuration menu - View commit details
-
Copy full SHA for 4c27449 - Browse repository at this point
Copy the full SHA 4c27449View commit details -
Put all configuration attributes under a
broker
namespaceNext stop, dynamically generate configuration properties.
Configuration menu - View commit details
-
Copy full SHA for 83259d7 - Browse repository at this point
Copy the full SHA 83259d7View commit details -
Generate property keys from
broker
attributesInstead of defining _ALL_ possible configuration attributes in `attributes/default.rb` we’ll generate key-value pair from whatever attributes that are found under the `broker` namespace. The diffs in this commit are so _HORRIBLE_, but I couldn’t think of any other way to get this done. There are still some tests that needs to be rewritten / added, and I do believe that the configuration generation creates some unnecessary whitespace / newlines that needs to be dealt with, but everything has it’s time, mkay? This is going to be so much easier to maintain.
Configuration menu - View commit details
-
Copy full SHA for 790fb46 - Browse repository at this point
Copy the full SHA 790fb46View commit details -
Allow
dotted
notation for broker configurationThis commit makes it possible to use either underscored symbol keys for configuration attributes (i.e. attributes defined under `broker`), or to use a `dotted` String notation, i.e. ``` node.set.broker = {‘log.dirs’ => %w[/some/dir-1 /some/dir-2]} ``` Decided to get rid of support for using nested Hashes as it’ll become difficult to render Hash-based options (CSV strings) correctly, and due to the naming of some of the configuration parameters it’s not possible to use `node.default.this.attribute = ‘something’` as the parameters include `default`, `fetch` and whatever else. Removed a lot of unit tests that are unnecessary now that the broker configuration file is dynamically rendered.
Configuration menu - View commit details
-
Copy full SHA for 46bd6b0 - Browse repository at this point
Copy the full SHA 46bd6b0View commit details -
Leave “mixed” configuration names as-is
If there’s a configuration parameter that contains both underscore and dots we don’t want to convert underscores to dots (for obvious reasons).
Configuration menu - View commit details
-
Copy full SHA for 7618121 - Browse repository at this point
Copy the full SHA 7618121View commit details -
Allow nested Hash notation for broker configuration
So, decided to re-introduce the nested Hash notation for accessing configuration attributes, as such: `node.default.broker[:hash][:option] = ‘value’` It does however mean that the “per topic” attributes cannot use Hashes anymore, but either Arrays or just plain Strings.
Configuration menu - View commit details
-
Copy full SHA for ad6c52f - Browse repository at this point
Copy the full SHA ad6c52fView commit details -
Update headers in template files
Just a heads up.
Configuration menu - View commit details
-
Copy full SHA for f6f080f - Browse repository at this point
Copy the full SHA f6f080fView commit details -
Remove unused config. related partials
Not used since the configuration rendering is done using helper methods rather than partials.
Configuration menu - View commit details
-
Copy full SHA for 81c18c8 - Browse repository at this point
Copy the full SHA 81c18c8View commit details -
Use
dotted
notation rather thanhash
notationBecause I like it better, mkay?
Configuration menu - View commit details
-
Copy full SHA for ce8bc9f - Browse repository at this point
Copy the full SHA ce8bc9fView commit details -
Was only needed for setting up ZooKeeper with a different configuration file from what Kafka was using.
Configuration menu - View commit details
-
Copy full SHA for df27c88 - Browse repository at this point
Copy the full SHA df27c88View commit details -
Was only needed for setting up ZooKeeper with a different configuration file from what Kafka was using.
Configuration menu - View commit details
-
Copy full SHA for ab7f7d4 - Browse repository at this point
Copy the full SHA ab7f7d4View commit details -
Use
jmx_port
directly from attributePreviously ZooKeeper and Kafka had different JMX ports, but used the same template for rendering the configuration file. Now that setting up ZooKeeper is out of the picture we don’t need this anymore.
Configuration menu - View commit details
-
Copy full SHA for 2d3454d - Browse repository at this point
Copy the full SHA 2d3454dView commit details -
Rather define levels individually for loggers. Don’t forget those trailing commas, yo!
Configuration menu - View commit details
-
Copy full SHA for c972e96 - Browse repository at this point
Copy the full SHA c972e96View commit details -
Update README w.r.t. new broker configuration attrs.
Just a heads up for the peoples. Could be expanded to explain some corner cases and whatnot. [ci skip]
Configuration menu - View commit details
-
Copy full SHA for 9846634 - Browse repository at this point
Copy the full SHA 9846634View commit details -
The modules are already namespaced, no need to namespace the individual files as well.
Configuration menu - View commit details
-
Copy full SHA for f17d9e4 - Browse repository at this point
Copy the full SHA f17d9e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6c8fb6 - Browse repository at this point
Copy the full SHA b6c8fb6View commit details -
Fix kafka installation on Opsworks
Chef's file cache path is apparently only readable by `root` on OpsWorks, so we have to extract the release archive as root and then manually set ownership.
Configuration menu - View commit details
-
Copy full SHA for 274eb97 - Browse repository at this point
Copy the full SHA 274eb97View commit details -
Account for different ways of defining
log.dirs
The (obvious) downside of having too many ways of defining configuration attributes. Perhaps I’ll revise that decision in the future, but for now it’s not too much of a hassle.
Configuration menu - View commit details
-
Copy full SHA for 8455cec - Browse repository at this point
Copy the full SHA 8455cecView commit details -
Quite a “large” release with a ton of changes, ranging from a rewrite of how “configuration attributes” are managed to minor fixups: * Removal of `zookeeper` recipe. Use a dedicated cookbook for that. * Host all “configuration attributes” under a `broker` namespace. * Configurable and sane log4j properties (see `attributes/default.rb` for examples). * Configurable KAFKA_GC_LOG_OPTS environment variable through the `gc_log_opts` attribute. * Bugfix for using this cookbook with AWS OpsWorks (thanks to @pfleidi).
Configuration menu - View commit details
-
Copy full SHA for 95a37e3 - Browse repository at this point
Copy the full SHA 95a37e3View commit details -
Fix incorrect attribute syntax in README
[ci skip]
Configuration menu - View commit details
-
Copy full SHA for 8bb6f0c - Browse repository at this point
Copy the full SHA 8bb6f0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e96d11 - Browse repository at this point
Copy the full SHA 5e96d11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a90e34 - Browse repository at this point
Copy the full SHA 1a90e34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ef18d0 - Browse repository at this point
Copy the full SHA 0ef18d0View commit details -
Set defaults in a separate (private) recipe
Since one can define broker configuration options in a number of different ways we cannot really set broker defaults in an attributes file. Instead we set them in a `_defaults` recipe, but only if they aren’t already set to something, as we don’t want to override what a user has already set. Closes sous-chefs#55.
Configuration menu - View commit details
-
Copy full SHA for bb0c633 - Browse repository at this point
Copy the full SHA bb0c633View commit details -
Bug fix release with a fix for sous-chefs#55.
Configuration menu - View commit details
-
Copy full SHA for 05061d0 - Browse repository at this point
Copy the full SHA 05061d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e3e946 - Browse repository at this point
Copy the full SHA 6e3e946View commit details -
Fix
date_pattern
fuck up for log4j appendersWow, that sucked pretty bad, sorry about that.
Configuration menu - View commit details
-
Copy full SHA for 9fe9ea7 - Browse repository at this point
Copy the full SHA 9fe9ea7View commit details -
Bug fix release for weird default `date_pattern` for log4j appenders.
Configuration menu - View commit details
-
Copy full SHA for f1c0168 - Browse repository at this point
Copy the full SHA f1c0168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 198921f - Browse repository at this point
Copy the full SHA 198921fView commit details -
It’s essentially CentOS, but since I’ve been testing this cookbook on EC2 with instances running Amazon Linux I might as well add it, as it seems like a thing people do.
Configuration menu - View commit details
-
Copy full SHA for 095040d - Browse repository at this point
Copy the full SHA 095040dView commit details -
Respect
controlled.shutdown.enable
in init scriptsBasically don’t force-kill the Kafka process if `controlled.shutdown. enable` is set to true. While it’s not necessarily a problem to force- kill the process, it does take quite some time to verify all the logs when it starts up again, and sort of defeats the purpose of even setting the option in the first place. From what I can tell from the upstart documentation it doesn’t try to kill an application if it doesn’t shutdown from the first signal, though I haven’t verified that this is the case.
Configuration menu - View commit details
-
Copy full SHA for a28be98 - Browse repository at this point
Copy the full SHA a28be98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56021e4 - Browse repository at this point
Copy the full SHA 56021e4View commit details -
Wait indef. for a controlled shutdown for RedHat distros
Thought it would be a lot nicer to actually wait for Kafka to shutdown when `controlled.shutdown.enable` is set to `true`, so that one can use the `restart` action. Unfortunately I had to write a simplified version of `killproc` to actually get this to work. I hate init scripts.
Configuration menu - View commit details
-
Copy full SHA for 2a6363c - Browse repository at this point
Copy the full SHA 2a6363cView commit details -
Wait indef. for a controlled shutdown on Debian
If I understand the documentation for `start-stop-daemon`, giving a `—signal` parameter it won’t force-kill a process.
Configuration menu - View commit details
-
Copy full SHA for 62e1f77 - Browse repository at this point
Copy the full SHA 62e1f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6af2637 - Browse repository at this point
Copy the full SHA 6af2637View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7816c9 - Browse repository at this point
Copy the full SHA e7816c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c685087 - Browse repository at this point
Copy the full SHA c685087View commit details -
Making default for ulimit_file nil.
It'll only apply if you set it. For sous-chefs#56.
Configuration menu - View commit details
-
Copy full SHA for 28499e8 - Browse repository at this point
Copy the full SHA 28499e8View commit details -
Remove
non-nil
checks forulimit_file
optionNot really necessary. If one set’s it to `false`, it’s their problem.
Configuration menu - View commit details
-
Copy full SHA for d7e3f93 - Browse repository at this point
Copy the full SHA d7e3f93View commit details -
Add int. test(s) for
ulimit_file
optionDefinitely not the prettiest tests I’ve written, but they do the job.
Configuration menu - View commit details
-
Copy full SHA for 91569a1 - Browse repository at this point
Copy the full SHA 91569a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b580b - Browse repository at this point
Copy the full SHA 30b580bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ee1a0 - Browse repository at this point
Copy the full SHA 76ee1a0View commit details -
Add (experimental) support for systemd as an
init_style
First stab at getting `systemd` to work. Still not sure about a few things such as using an EnvironmentFile and the code for setting up everything related to init styles is even messier, so it could probably use some cleanup and rethinking. But hey, it works.
Configuration menu - View commit details
-
Copy full SHA for e9a60df - Browse repository at this point
Copy the full SHA e9a60dfView commit details
Commits on Oct 17, 2014
-
John M committed
Oct 17, 2014 Configuration menu - View commit details
-
Copy full SHA for 9ad7910 - Browse repository at this point
Copy the full SHA 9ad7910View commit details -
Add explicit filename for the log4j and server properties
John M committedOct 17, 2014 Configuration menu - View commit details
-
Copy full SHA for 52568f2 - Browse repository at this point
Copy the full SHA 52568f2View commit details -
Cleanup unused ERB tags and fixed the JMX_PORT tag
John M committedOct 17, 2014 Configuration menu - View commit details
-
Copy full SHA for 9b31127 - Browse repository at this point
Copy the full SHA 9b31127View commit details