Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSUL-543] Create exec_supported.go #89

Merged

Conversation

joselo85
Copy link

@joselo85 joselo85 commented Nov 9, 2022

Description

Created exec_supported.go to avoid code duplication. We've collected the shared functions and variables between exec_windows.go and exec_unix.go in this file. Now exec_windows and exec_unix only contain code for their respective platforms.

@joselo85 joselo85 requested a review from ezfepo November 9, 2022 18:14
@joselo85 joselo85 self-assigned this Nov 9, 2022
@ezfepo ezfepo merged commit 31dae08 into qa-consul Nov 9, 2022
@ezfepo ezfepo deleted the consulwindows/go/consul-543-create-exec_supported.go branch November 9, 2022 19:04
ezfepo pushed a commit that referenced this pull request Nov 11, 2022
joselo85 added a commit that referenced this pull request Dec 21, 2022
joselo85 added a commit that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants