Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Issue/#18 build pipeline #19

Merged
merged 12 commits into from
Oct 21, 2022

Conversation

managedkaos
Copy link
Contributor

@managedkaos managedkaos commented Oct 21, 2022

Solution for #18

  • Build is run on all versions of Python for:
    • ubuntu-latest
    • windows-latest
    • macos-latest

To update the build job to use all operating systems, the Black Code Formatter and Mypy Check actions were moved to a job named check. This was needed because these actions require a Linux-based runner.

The build job was updated to require check to pass before starting.

This prevents having to skip the Black Code Formatter and Mypy Check actions in the build job for windows-latest and macos-latest while allowing all build jobs to benefit from the checks.

The current triggers require a push or PR to exercise the pipeline. Adding this trigger will allow the pipeline to be run without having to modify any code.
for Black Code Formatter build step
For Mypy check build step
They are check actions not critical for the build so makes sense to have them in a different job running on Linux (since the actions require linux) and then have the build job depend on the check job.
@managedkaos
Copy link
Contributor Author

Check out this workflow run for a preview of this PR.

Fixes the following in workflow runs:
```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout
```
@managedkaos
Copy link
Contributor Author

managedkaos commented Oct 21, 2022

This workflow run has the latest updates for the checkout and setup-python actions.

Note that the warnings for set-output are a known issue:
https://hynek.me/til/set-output-deprecation-github-actions/

These warnings can't be cleaned up in user-defined workflows...the fix needs to be applied to the actions used in the workflow.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@managedkaos
Copy link
Contributor Author

Thanks! I saw the 3.11-dev in the other PR and thought to add it in mine just in case. Workflows have been updated.

@codecov-commenter
Copy link

Codecov Report

Base: 99.28% // Head: 99.28% // No change to project coverage 👍

Coverage data is based on head (26d5e49) compared to base (fc52716).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          31       31           
  Lines         839      839           
=======================================
  Hits          833      833           
  Misses          6        6           
Flag Coverage Δ
unittests 99.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@sp1thas sp1thas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @managedkaos

@sp1thas sp1thas merged commit 3e97b45 into sp1thas:master Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants