-
-
Notifications
You must be signed in to change notification settings - Fork 6
Issue/#18 build pipeline #19
Issue/#18 build pipeline #19
Conversation
The current triggers require a push or PR to exercise the pipeline. Adding this trigger will allow the pipeline to be run without having to modify any code.
for Black Code Formatter build step
For Mypy check build step
They are check actions not critical for the build so makes sense to have them in a different job running on Linux (since the actions require linux) and then have the build job depend on the check job.
Check out this workflow run for a preview of this PR. |
Fixes the following in workflow runs: ``` Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout ```
v3 -> v4
This workflow run has the latest updates for the Note that the warnings for These warnings can't be cleaned up in user-defined workflows...the fix needs to be applied to the actions used in the workflow. |
Thanks! I saw the |
Codecov ReportBase: 99.28% // Head: 99.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 31 31
Lines 839 839
=======================================
Hits 833 833
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @managedkaos
Solution for #18
ubuntu-latest
windows-latest
macos-latest
To update the
build
job to use all operating systems, theBlack Code Formatter
andMypy Check
actions were moved to a job namedcheck
. This was needed because these actions require a Linux-based runner.The
build
job was updated to requirecheck
to pass before starting.This prevents having to skip the
Black Code Formatter
andMypy Check
actions in thebuild
job forwindows-latest
andmacos-latest
while allowing allbuild
jobs to benefit from the checks.